fix(ui): prevent wrong scroll target when adding rows in repeated array blocks #15047
+131
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay blocks \## What? Adding rows to an array field inside repeated Lexical blocks sometimes scrolls to the first block instead of the block where the row was added. \## Why? Row elements share the same DOM id because the parent path isn’t made unique per block in Lexical, so `scrollToID` matches the first occurrence. \## How? Add a block-unique prefix into the array field path/id generation when rendering array fields, ensuring each block’s rows have distinct DOM ids and scroll targets. Fixes: payloadcms#14333
Robot-Inventor
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding rows to an array field inside repeated Lexical blocks sometimes scrolls to the first block instead of the block where the row was added.
Why?
Row elements share the same DOM id because the parent path isn’t made unique per block in Lexical, so
scrollToIDmatches the first occurrence.How?
Add a block-unique prefix into the array field path/id generation when rendering array fields, ensuring each block’s rows have distinct DOM ids and scroll targets.
Fixes: #14333