Skip to content

Fix: Handle optional 'localized' and 'required' fields in DuplicateDocument component #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Harsha707 wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Fix: Handle optional 'localized' and 'required' fields in DuplicateDocument component #8232

Harsha707 wants to merge 1 commit into from

Conversation

@Harsha707
Copy link

@Harsha707 Harsha707 commented Sep 16, 2024 •
edited
Loading

Pull Request Description:

This PR fixes an issue in the DuplicateDocument component where optional fields such as localized, required, and name were accessed without checks, causing potential errors.

Since there is no backend endpoint to handle this, unlike in V3, the issue needs to be addressed in the frontend. This PR mirrors the behavior from V3 by safely checking for these optional fields before accessing them.

Key Changes:

  • Added checks to ensure fields like localized and required are accessed only if they exist.
  • Safely handled the name field, preventing errors when it's not defined.
  • Ensures document duplication works properly even when these fields are missing.

This solution mimics V3 functionality and ensures robust duplication handling on the frontend in the absence of a backend solution.

Fixes #7270
@DanRibbens DanRibbens added the keep Prevents from being marked stale or auto-closed. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep Prevents from being marked stale or auto-closed. stale v2

3 participants

@Harsha707 @denolfe @DanRibbens