Skip to content

fix: resolve E501 pycodestyle line-too-long in llm tools database module#10003

Merged
asheshv merged 1 commit into
pgadmin-org:masterfrom
hiteshjambhale:fix/pycodestyle-e501-llm-tools-database
Jun 5, 2026
Merged

fix: resolve E501 pycodestyle line-too-long in llm tools database module#10003
asheshv merged 1 commit into
pgadmin-org:masterfrom
hiteshjambhale:fix/pycodestyle-e501-llm-tools-database

Conversation

@hiteshjambhale

@hiteshjambhale hiteshjambhale commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a pycodestyle E501 violation in web/pgadmin/llm/tools/database.py.

The _connect_readonly function signature exceeded the 79-character line limit. The signature has been wrapped across multiple lines to comply with the project's pycodestyle configuration.

Changes

  • web/pgadmin/llm/tools/database.py: Wrapped _connect_readonly function signature to fix E501 line-too-long error.

Verification

$ pycodestyle --config=.pycodestyle web/pgadmin/llm/tools/database.py
# No output — all checks pass

Summary by CodeRabbit

  • Style
    • Minor formatting updates to improve code readability.
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b7fc17b-bc7c-4612-a6fd-2b41fd0249e3

📥 Commits

Reviewing files that changed from the base of the PR and between 2dc9d71 and de73a97.

📒 Files selected for processing (1)
  • web/pgadmin/llm/tools/database.py

Walkthrough

The PR reformats the _connect_readonly helper function's signature in web/pgadmin/llm/tools/database.py by splitting it across multiple lines. No semantic changes to parameters, return type, or implementation are introduced.

Changes

Function Signature Reformatting

Layer / File(s) Summary
Function signature line wrapping
web/pgadmin/llm/tools/database.py
The _connect_readonly function definition is reformatted across multiple lines, maintaining the same tuple[bool, Optional[str]] return annotation and all parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • pgadmin-org/pgadmin4#9993: Both PRs modify the _connect_readonly helper in web/pgadmin/llm/tools/database.py by adjusting its formatting without changing behavior.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a pycodestyle E501 line-too-long violation in the specified module by reformatting the function signature.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asheshv asheshv merged commit 679c39f into pgadmin-org:master Jun 5, 2026
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants