Enhancement: Allow export/download of all generated TLGs - #1428
Open
h5hoang wants to merge 14 commits into
Open
Conversation
6 tasks
h5hoang
changed the base branch from
main
to
1335-enhancement-simplify-tlg-order-details-table-and-internalize-pcspec-filtering
August 11, 2026 20:54
Base automatically changed from
1335-enhancement-simplify-tlg-order-details-table-and-internalize-pcspec-filtering
to
main
August 24, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1344
Description
Rendered TLGs can now be exported. They appear as a branch in the existing Export as ZIP dialog, alongside the other results, once a TLG order has been submitted:
Getting the outputs out of the modules:
tlg_module_serverreturns itstlg_listreactive instead of nothing, andtab_tlg_serverkeeps those in a per-session registry, so the export writes what is actually on screen — sidebar option edits included — rather than re-running the catalog with defaultssuspendWhenHidden; without that, a tab the user never opened contributed nothing to the exportFormats (
inst/shiny/functions/zip-utils.R):F - Geometric Meanmanifest.csvand skipped,Everything else:
inst/shiny/functions/tlg_export.Rhandles file naming, the folder layout and the manifestsave_dispatch()gained PDF, XLSX and plotly→PNG rather than growing a second writer alongside it.make_zip_filename()takes a suffix so both exports share the project/study namingmanifest.csvand skipped, so one broken output does not cost the user the other thirtyDefinition of Done
Graphs/,Tables/,Listings/pkcg01_lin_DrugA.png)How to test
manifest.csv, that PNGs are not blank, and that the XLSX files openContributor checklist
.scsschange was done, rundata-raw/compile_css.Rdata-raw/test_suggests_hidden.RNotes to reviewer