Redesign ADPP Exclusions tab and route descriptive stats through ADPP - #1467
Draft
Gero1999 wants to merge 1 commit into
Draft
Redesign ADPP Exclusions tab and route descriptive stats through ADPP#1467Gero1999 wants to merge 1 commit into
Gero1999 wants to merge 1 commit into
Conversation
Rework the ADPP Exclusions tab (now the third Results sub-tab): - Colour-code excluded records by source: red (flag rule), yellow (custom/user), orange (both), shared by table rows and boxplot crosses. - Embed multi-parameter violin/box plots; 'Select PPs' accepts multiple parameters and the exclusion table is filtered to the selection. - Add a 'Filter PPs' control (All / flagged / with an outlier). Outliers use the Tukey/IQR rule within the current X/colour grouping over non-excluded records only. - Click a boxplot point to highlight the matching table row. Route descriptive statistics through ADPP as the single grouping and exclusion source, removing the ad-hoc join from concentration data. Add exported helpers is_iqr_outlier() and params_with_outliers(). Closes #1466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1466
Description
Reworks the ADPP Exclusions tab and routes descriptive statistics through ADPP to make the exclusion workflow clearer and the grouping logic more robust.
ADPP Exclusions tab (now the third Results sub-tab):
Data flow:
New exported helpers:
is_iqr_outlier()andparams_with_outliers().Definition of Done
How to test
Contributor checklist
.scsschange was done, rundata-raw/compile_css.Rdata-raw/test_suggests_hidden.RNotes to reviewer
devtools::document(),lintr::lint_package(), anddevtools::test()could not be run here. The two newman/*.Rdfiles andNAMESPACEexports were updated by hand; please rundevtools::document()and the test/lint suite before merging.