Added ard_hierarchical() and ard_hierarchical_count() - #82
Merged
Conversation
bzkrouse
approved these changes
Dec 18, 2023
bzkrouse
left a comment
Collaborator
There was a problem hiding this comment.
Great addition!!! Just 1 small request - it would be super helpful if there was something in the docs about how ard_hierarchical_count() computes results for all variables, and ard_hierarchical only computes results for the lowest level variable. Would it be possible to add that? Approving this as I don't need to review again :)
Collaborator
Author
|
@bzkrouse ah yes! Great point :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
ard_hierarchical()andard_hierarchical_count()Reference GitHub issue associated with pull request. e.g., 'closes #1'
closes #54
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::install_dev_deps()usethis::pr_merge_main()pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again