Skip to content

Fix collection name is not persisted #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Fix collection name is not persisted #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions collection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,16 @@ func newCollection(name string, metadata map[string]string, embed EmbeddingFunc,
if err != nil {
return nil, fmt.Errorf("couldn't create collection directory: %w", err)
}
// Persist metadata
// Persist name and metadata
metadataPath := path.Join(c.persistDirectory, metadataFileName)
err = persist(metadataPath, m)
pc := struct {
Name string
Metadata map[string]string
}{
Name: name,
Metadata: m,
}
err = persist(metadataPath, pc)
if err != nil {
return nil, fmt.Errorf("couldn't persist collection metadata: %w", err)
}
Expand Down