Export Document struct and add Go-idiomatic methods for adding them to a collection #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking Document objects instead of individual ids/metadata/embeddings/content parameters. Move doc metadata copying from constructor to addition to collection, as we don't use the map before it's added to the collection
To match the refactoring in Collection.AddDocuments from the previous commit
To differentiate between our now exported Document struct and its contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely
AddDocument()andAddDocuments(), taking the newly exportedDocumentstruct as parameter.This PR also includes some changes of prior "document" mentions to "content" or "text" to avoid misunderstandings.
As well as a refactoring of the error handling in the parallelization code due to two errors requiring handling when documents are added concurrently (and while doing that it made sense to adapt the error handling in the
Querymethod in the same way).The example code is also changed to use the new methods.