Skip to content

Fix metadatas validation in AddConcurrently() #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix metadatas validation in AddConcurrently() #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix metadatas validation in AddConcurrently()
  • Loading branch information
@philippgille
philippgille committed Mar 4, 2024
commit 5f1568b617eefa77963e648514842c6e38c9a779
9 changes: 7 additions & 2 deletions collection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,13 @@ func (c *Collection) AddConcurrently(ctx context.Context, ids []string, embeddin
// Assign empty slice so we can simply access via index later
embeddings = make([][]float32, len(ids))
}
if len(metadatas) != 0 && len(ids) != len(metadatas) {
return errors.New("ids, metadatas and contents must have the same length")
if len(metadatas) != 0 {
if len(ids) != len(metadatas) {
return errors.New("when metadatas is not empty it must have the same length as ids")
}
} else {
// Assign empty slice so we can simply access via index later
metadatas = make([]map[string]string, len(ids))
}
if len(contents) != 0 {
if len(contents) != len(ids) {
Expand Down