Skip to content

Fix param validation #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Fix param validation #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b7e80
Fix nResults validation
philippgille Mar 17, 2024
98516b1
Add unit test for query errors
philippgille Mar 17, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix nResults validation
  • Loading branch information
@philippgille
philippgille committed Mar 17, 2024
commit a8b7e80e6aa839d425fa5e1a2e0539b5eeef5948
4 changes: 2 additions & 2 deletions collection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ func (c *Collection) Query(ctx context.Context, queryText string, nResults int,
}
c.documentsLock.RLock()
defer c.documentsLock.RUnlock()
if nResults < len(c.documents) {
return nil, errors.New("nResults must be greater than the number of documents in the collection")
if nResults > len(c.documents) {
return nil, errors.New("nResults must be <= the number of documents in the collection")
}

if len(c.documents) == 0 {
Expand Down