Skip to content

Conversation

@iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented May 10, 2024

Azure requires

  1. Passing the API Key via a header api-key
  2. Passing the api-version as a query parameter

I know this is a breaking change, so I just put this here for discussion. @philippgille

@philippgille
Copy link
Owner

WDYT about adding a non-exported function that takes and handles these two additional parameters, and then both the NewEmbeddingFuncOpenAICompat and the NewEmbeddingFuncAzureOpenAI call that one, while the former stays backward-compatible and its param list is sufficient and simpler for most OpenAI-compatible APIs?

@iwilltry42
Copy link
Contributor Author

@philippgille sounds good to me - done ✔️

@iwilltry42 iwilltry42 changed the title [DRAFT] add: AzureOpenAI compatibility May 13, 2024
@iwilltry42 iwilltry42 marked this pull request as ready for review May 13, 2024 08:02
@philippgille
Copy link
Owner

Thank you for the contribution! 🙇‍♂️

@philippgille philippgille merged commit aa151c6 into philippgille:main May 13, 2024
philippgille added a commit that referenced this pull request Jul 13, 2024
hungrymonkey pushed a commit to soundprediction/chromem-go that referenced this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants