support double quotes in table names - #113
Merged
Merged
Conversation
piskvorky
reviewed
Jul 5, 2020
Co-authored-by: Radim Řehůřek <me@radimrehurek.com>
Contributor
Author
|
BTW. |
piskvorky
requested changes
Jul 6, 2020
Contributor
Author
|
FYI, sqlite identifiers are "kind of" case insensitive, but just on the ASCII characters, so:
but It messes with the philosophy of this project a bit if you think of table names as keys. In particular the solution on #84 should break sometimes due to this "case insensitiveness" |
piskvorky
reviewed
Jul 8, 2020
Co-authored-by: Radim Řehůřek <me@radimrehurek.com>
Co-authored-by: Radim Řehůřek <me@radimrehurek.com>
mpenkov
approved these changes
Aug 21, 2020
Collaborator
|
Merged. Thank you for your contribution, @vcalv ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112