Skip to content

Clean up license file names - #99

Merged
mpenkov merged 2 commits into
piskvorky:masterfrom
r-barnes:master
Aug 23, 2019
Merged

Clean up license file names#99
mpenkov merged 2 commits into
piskvorky:masterfrom
r-barnes:master

Conversation

@r-barnes

Copy link
Copy Markdown

Removes one license file, renames the other. The result is that Github recognizes the license automagically:

Github recognizes license

@r-barnes r-barnes mentioned this pull request Aug 20, 2019
@piskvorky

piskvorky commented Aug 20, 2019

Copy link
Copy Markdown
Owner

Is it safe to delete LICENSE.rst? What was it there for, which process / tool used it? (= what broke after its removal; the usual suspects are PyPI, CI, Github)

@r-barnes

Copy link
Copy Markdown
Author

It was good to check: I fixed references in MANIFEST.in. As to its original purpose, I don't know.

It's not Github, because this PR is to fix the problem on GitHub. There's a travis file, but CI isn't enabled for PRs, so I'm not sure how to test. I don't see documentation for PyPI discussing a "license.rst" file.

@r-barnes

Copy link
Copy Markdown
Author

@toddrme2178 added the file. Can they speak to this?

@mpenkov

mpenkov commented Aug 23, 2019

Copy link
Copy Markdown
Collaborator

This looks like it's good to merge.

@mpenkov
mpenkov merged commit b8137a9 into piskvorky:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants