This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Prevent navigation out of initial origin #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't log requests to and responses from `/static`, `/images` and `/settings/urls`.
Contributor
Author
tarzzz
reviewed
May 18, 2018
| mainWindow.webContents.on('will-navigate', (event, url) => { | ||
| if (!url.startsWith(HTTP_URL)) event.preventDefault(); | ||
| }); | ||
|
|
tarzzz
approved these changes
May 18, 2018
Contributor
tarzzz
left a comment
tarzzz
left a comment
There was a problem hiding this comment.
Looks good,
💃 after testing to make sure it works as intended, and does not affect OAuth logins.. !!
Contributor
Contributor
Author
|
Contributor
|
Ok, I will check onprem (Not today, probably monday) ..
…On Fri, May 18, 2018 at 11:52 AM, Nicolas Riesco ***@***.***> wrote:
@tarzzz <https://github.com/tarzzz>
- the reason I opened #438
<#438> is that I
don't want nodeIntegration in this PR.
- I can't test the on-prem case, please, could you test this PR
doesn't break oauth?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeZJE6zbTY-t8qz2JqQu982JqPpL-hDks5tzu41gaJpZM4UDtKt>
.
|
Contributor
Author
Contributor
|
Yeah, we should be good to merge it because the issue is only applicable on the electron app. drag-and-drop on browser version will simply load the new url in that tab. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes plotly/streambed#10963
Closes #433