fix: Include type defs in appropriate partial bundles - #8001
Merged
Conversation
camdecoster
marked this pull request as ready for review
August 31, 2026 22:19
emilykl
previously approved these changes
Sep 1, 2026
emilykl
left a comment
emilykl
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Can you add a clear comment towards the top of sync_packages.js stating exactly which bundles have the types files included?
Contributor
Author
|
Looking at it again, this doesn't need to wait for #8000 to merge. |
emilykl
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include the type definitions in the
plotly.js-dist,plotly.js-dist-minpartial bundles.Closes #7996.
Changes
Testing
DRYRUN=1 node tasks/sync_packages.jsNotes
I'm going to open another issue to track thatAn issue already exists: Webpack v5 compatibility issue (with workaround) #6014