Skip to content

update plotly.js to v3.3.0#5421

Merged
emilykl merged 4 commits intomainfrom
update-plotlyjs-3.3.0
Nov 17, 2025
Merged

update plotly.js to v3.3.0#5421
emilykl merged 4 commits intomainfrom
update-plotlyjs-3.3.0

Conversation

@emilykl
Copy link
Contributor

@emilykl emilykl commented Nov 17, 2025

@emilykl emilykl force-pushed the update-plotlyjs-3.3.0 branch from 41ba335 to 83ab425 Compare November 17, 2025 16:56
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camdecoster fyi: Turns out package-lock.json inherits its indentation from package.json by default, so if we keep package.json at 2 spaces, package-lock.json needs to be two spaces as well.

a3480f0 changes the indentation, 83ab425 updates the actual contents of the lockfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a fun world we live in. For future reference, here's the doc page describing this:

When npm creates or updates package-lock.json, it will infer line endings and indentation from package.json so that the formatting of both files matches.

@emilykl emilykl force-pushed the update-plotlyjs-3.3.0 branch from 56873c3 to f687526 Compare November 17, 2025 17:29
@emilykl emilykl requested a review from camdecoster November 17, 2025 17:48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a fun world we live in. For future reference, here's the doc page describing this:

When npm creates or updates package-lock.json, it will infer line endings and indentation from package.json so that the formatting of both files matches.

@emilykl emilykl merged commit a49f495 into main Nov 17, 2025
10 checks passed
@emilykl emilykl deleted the update-plotlyjs-3.3.0 branch November 17, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants