Rename /public to /assets, as the latter is the special directory#212
Open
glebius wants to merge 1 commit into
Open
Rename /public to /assets, as the latter is the special directory#212glebius wants to merge 1 commit into
glebius wants to merge 1 commit into
Conversation
for a Gem based theme. See https://jekyllrb.com/docs/themes/. This fixes operation of hyde with jekyll-remote-theme.
Member
|
As far as I know, there's nothing special about |
Author
|
Exactly, there is nothing special about "public", but there is about "assets". And we need it be special to be copied over. |
Member
|
Oh well shit, I misread that one. I dunno when I'll get to this and the other themes though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I tried to use hyde together with https://github.com/benbalter/jekyll-remote-theme. This gem allows to host a website with GitHub Pages with any GitHub-hosted theme (not only supported by Pages). It puts remote theme to a temporary directory, compiles _site and deletes temporary. This yielded in files missing from the generated website:
[2017-11-21 00:43:00] ERROR
/public/css/poole.css' not found. [2017-11-21 00:43:00] ERROR/public/css/syntax.css' not found.[2017-11-21 00:43:00] ERROR `/public/css/hyde.css' not found.
This happens because Jekyll doesn't treat /public as a special directory. See https://jekyllrb.com/docs/themes/. Putting stylesheets and icons into /assets fixes the problem.