Skip to content

Fix comments with indents - #549

Merged
asottile merged 1 commit into
pre-commit:masterfrom
greshilov:fix-comments-with-indents
Jan 17, 2021
Merged

Fix comments with indents#549
asottile merged 1 commit into
pre-commit:masterfrom
greshilov:fix-comments-with-indents

Conversation

@greshilov

Copy link
Copy Markdown
Contributor

Fix for #548.

Comment thread requirements-dev.txt Outdated
covdefaults
coverage
pytest
ruamel.yaml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

I was unable to run tests without this package.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably have extremely old setuptools / pip / tox / virtualenv-- upgrade those

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks like I misconfigured something.

@greshilov
greshilov force-pushed the fix-comments-with-indents branch from 54a8c0a to 093109e Compare January 17, 2021 19:14
@greshilov
greshilov force-pushed the fix-comments-with-indents branch from 093109e to 28b2c8e Compare January 17, 2021 19:15

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
asottile merged commit 43f5ffa into pre-commit:master Jan 17, 2021

@MasterSlave420 MasterSlave420 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ghost

ghost commented May 14, 2021

Copy link
Copy Markdown

Thanks for adding this.

@asottile do you know when the next release would be approximately?
There's a few additions I'd like to use, this included 😄

@asottile

Copy link
Copy Markdown
Member

Thanks for adding this.

@asottile do you know when the next release would be approximately?
There's a few additions I'd like to use, this included 😄

the next release will be when the next release is

please don't ask for releases (from anyone, not just me), it's borderline rude -- if you want free work consider sponsoring

@ghost

ghost commented May 14, 2021

Copy link
Copy Markdown

@asottile ,
Sorry, about that.
I’ve better informed myself and I now see that was very bad etiquette on my behalf. Thank you for correcting it :)


I appreciate you and your work.





Please accept my apology. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants