Skip to content

Fix check-useless-exclude to consider types filter #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asottile merged 1 commit into from
Oct 2, 2018
Merged

Fix check-useless-exclude to consider types filter #837

asottile merged 1 commit into from
Oct 2, 2018

Conversation

@georgeyk
Copy link
Contributor

@georgeyk georgeyk commented Oct 2, 2018

Fixes #704
asottile
asottile approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is great!

If you're looking for another starter issue this one has some code hints :)
@georgeyk
Copy link
Contributor Author

georgeyk commented Oct 2, 2018

Thanks @asottile I'll take a look o/
@asottile asottile merged commit c0b1f2f into pre-commit:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@georgeyk @asottile