Skip to content

Add support for rendering comment nodes #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
andrewiggins wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support for rendering comment nodes #3957

andrewiggins wants to merge 1 commit into from

Conversation

@andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Mar 31, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 31, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +3% (-4.91ms - +5.43ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-1.98ms - +0.76ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-6.75ms - +10.32ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +3% (-0.54ms - +0.80ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +1% (-3.42ms - +1.21ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +4% (-1.16ms - +1.48ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +2% (-0.04ms - +0.05ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +2% (-0.46ms - +1.32ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -10% - +5% (-0.38ms - +0.19ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.04ms - +0.02ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: faster ✔ 0% - 5% (0.04ms - 0.86ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master209.49ms - 216.83ms-unsure 🔍
-3% - +2%
-5.43ms - +4.91ms		unsure 🔍
-2% - +3%
-4.52ms - +5.54ms
preact-local209.79ms - 217.05msunsure 🔍
-2% - +3%
-4.91ms - +5.43ms		-unsure 🔍
-2% - +3%
-4.23ms - +5.77ms
preact-hooks209.21ms - 216.09msunsure 🔍
-3% - +2%
-5.54ms - +4.52ms		unsure 🔍
-3% - +2%
-5.77ms - +4.23ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.51ms - 3.98ms-unsure 🔍
-5% - +11%
-0.19ms - +0.38ms		unsure 🔍
-5% - +11%
-0.17ms - +0.38ms
preact-local3.49ms - 3.80msunsure 🔍
-10% - +5%
-0.38ms - +0.19ms		-unsure 🔍
-6% - +6%
-0.20ms - +0.22ms
preact-hooks3.50ms - 3.78msunsure 🔍
-10% - +4%
-0.38ms - +0.17ms		unsure 🔍
-6% - +6%
-0.22ms - +0.20ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master63.52ms - 66.88ms-unsure 🔍
-2% - +5%
-1.19ms - +3.26ms		unsure 🔍
-5% - +2%
-3.45ms - +1.18ms
preact-local62.71ms - 65.63msunsure 🔍
-5% - +2%
-3.26ms - +1.19ms		-faster ✔
0% - 6%
0.01ms - 4.33ms
preact-hooks64.74ms - 67.93msunsure 🔍
-2% - +5%
-1.18ms - +3.45ms		unsure 🔍
-0% - +7%
+0.01ms - +4.33ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master92.54ms - 95.82ms-unsure 🔍
-2% - +4%
-1.51ms - +3.35ms		unsure 🔍
-4% - +2%
-3.87ms - +1.55ms
preact-local91.47ms - 95.05msunsure 🔍
-4% - +2%
-3.35ms - +1.51ms		-unsure 🔍
-5% - +1%
-4.88ms - +0.72ms
preact-hooks93.19ms - 97.49msunsure 🔍
-2% - +4%
-1.55ms - +3.87ms		unsure 🔍
-1% - +5%
-0.72ms - +4.88ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master71.90ms - 76.89ms-unsure 🔍
-6% - +3%
-4.95ms - +2.52ms		unsure 🔍
-7% - +3%
-5.02ms - +2.26ms
preact-local72.83ms - 78.39msunsure 🔍
-3% - +7%
-2.52ms - +4.95ms		-unsure 🔍
-5% - +5%
-4.01ms - +3.68ms
preact-hooks73.12ms - 78.43msunsure 🔍
-3% - +7%
-2.26ms - +5.02ms		unsure 🔍
-5% - +5%
-3.68ms - +4.01ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master80.18ms - 85.06ms-unsure 🔍
-3% - +8%
-2.08ms - +6.14ms		unsure 🔍
-6% - +3%
-5.14ms - +2.41ms
preact-local77.28ms - 83.90msunsure 🔍
-7% - +2%
-6.14ms - +2.08ms		-unsure 🔍
-9% - +1%
-7.79ms - +0.99ms
preact-hooks81.10ms - 86.87msunsure 🔍
-3% - +6%
-2.41ms - +5.14ms		unsure 🔍
-1% - +10%
-0.99ms - +7.79ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master87.98ms - 91.49ms-unsure 🔍
-3% - +3%
-2.91ms - +2.67ms		faster ✔
0% - 6%
0.26ms - 5.84ms
preact-local87.69ms - 92.03msunsure 🔍
-3% - +3%
-2.67ms - +2.91ms		-unsure 🔍
-6% - +0%
-5.99ms - +0.15ms
preact-hooks90.61ms - 94.95msslower ❌
0% - 7%
0.26ms - 5.84ms		unsure 🔍
-0% - +7%
-0.15ms - +5.99ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master59.43ms - 64.10ms-unsure 🔍
-4% - +6%
-2.70ms - +3.95ms		unsure 🔍
-6% - +4%
-3.96ms - +2.58ms
preact-local58.78ms - 63.50msunsure 🔍
-6% - +4%
-3.95ms - +2.70ms		-unsure 🔍
-7% - +3%
-4.60ms - +1.97ms
preact-hooks60.17ms - 64.74msunsure 🔍
-4% - +6%
-2.58ms - +3.96ms		unsure 🔍
-3% - +8%
-1.97ms - +4.60ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master34.79ms - 36.69ms-unsure 🔍
-2% - +6%
-0.76ms - +1.98ms		unsure 🔍
-0% - +8%
-0.03ms - +2.78ms
preact-local34.15ms - 36.11msunsure 🔍
-5% - +2%
-1.98ms - +0.76ms		-unsure 🔍
-2% - +6%
-0.66ms - +2.19ms
preact-hooks33.33ms - 35.40msunsure 🔍
-8% - +0%
-2.78ms - +0.03ms		unsure 🔍
-6% - +2%
-2.19ms - +0.66ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.45ms - 3.45ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.45ms - 3.45msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.46ms - 3.47msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1325.24ms - 1335.44ms-unsure 🔍
-1% - +1%
-10.32ms - +6.75ms		unsure 🔍
-1% - +0%
-12.55ms - +2.09ms
preact-local1325.28ms - 1338.97msunsure 🔍
-1% - +1%
-6.75ms - +10.32ms		-unsure 🔍
-1% - +0%
-12.07ms - +5.18ms
preact-hooks1330.32ms - 1340.82msunsure 🔍
-0% - +1%
-2.09ms - +12.55ms		unsure 🔍
-0% - +1%
-5.18ms - +12.07ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.40ms - 25.44ms-unsure 🔍
-0% - +0%
-0.02ms - +0.04ms		unsure 🔍
-0% - +0%
-0.04ms - +0.02ms
preact-local25.39ms - 25.43msunsure 🔍
-0% - +0%
-0.04ms - +0.02ms		-unsure 🔍
-0% - +0%
-0.05ms - +0.01ms
preact-hooks25.41ms - 25.45msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms		unsure 🔍
-0% - +0%
-0.01ms - +0.05ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master24.53ms - 25.45ms-unsure 🔍
-3% - +2%
-0.80ms - +0.54ms		unsure 🔍
-3% - +3%
-0.74ms - +0.71ms
preact-local24.64ms - 25.61msunsure 🔍
-2% - +3%
-0.54ms - +0.80ms		-unsure 🔍
-3% - +3%
-0.63ms - +0.86ms
preact-hooks24.45ms - 25.57msunsure 🔍
-3% - +3%
-0.71ms - +0.74ms		unsure 🔍
-3% - +2%
-0.86ms - +0.63ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.58ms - 1.58ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.58ms - 1.58msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.60ms - 1.60msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master129.65ms - 132.96ms-unsure 🔍
-1% - +3%
-1.21ms - +3.42ms		unsure 🔍
-0% - +3%
-0.31ms - +3.95ms
preact-local128.59ms - 131.82msunsure 🔍
-3% - +1%
-3.42ms - +1.21ms		-unsure 🔍
-1% - +2%
-1.38ms - +2.81ms
preact-hooks128.15ms - 130.83msunsure 🔍
-3% - +0%
-3.95ms - +0.31ms		unsure 🔍
-2% - +1%
-2.81ms - +1.38ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master15.57ms - 16.06ms-slower ❌
0% - 6%
0.04ms - 0.86ms		unsure 🔍
-1% - +4%
-0.21ms - +0.57ms
preact-local15.03ms - 15.69msfaster ✔
0% - 5%
0.04ms - 0.86ms		-unsure 🔍
-5% - +1%
-0.72ms - +0.18ms
preact-hooks15.33ms - 15.93msunsure 🔍
-4% - +1%
-0.57ms - +0.21ms		unsure 🔍
-1% - +5%
-0.18ms - +0.72ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master37.56ms - 39.13ms-unsure 🔍
-4% - +3%
-1.48ms - +1.16ms		unsure 🔍
-4% - +3%
-1.41ms - +1.32ms
preact-local37.44ms - 39.56msunsure 🔍
-3% - +4%
-1.16ms - +1.48ms		-unsure 🔍
-4% - +4%
-1.43ms - +1.65ms
preact-hooks37.28ms - 39.51msunsure 🔍
-3% - +4%
-1.32ms - +1.41ms		unsure 🔍
-4% - +4%
-1.65ms - +1.43ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.63ms - 4.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-local4.63ms - 4.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-hooks4.63ms - 4.65msunsure 🔍
+0% - +0%
+0.01ms - +0.02ms		unsure 🔍
+0% - +0%
+0.01ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.81ms - 2.87ms-unsure 🔍
-2% - +1%
-0.05ms - +0.04ms		faster ✔
4% - 7%
0.13ms - 0.22ms
preact-local2.81ms - 2.88msunsure 🔍
-1% - +2%
-0.04ms - +0.05ms		-faster ✔
4% - 7%
0.12ms - 0.22ms
preact-hooks2.98ms - 3.05msslower ❌
4% - 8%
0.13ms - 0.22ms		slower ❌
4% - 8%
0.12ms - 0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.81ms - 0.81ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
2% - 2%
0.01ms - 0.01ms
preact-local0.81ms - 0.81msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
2% - 2%
0.01ms - 0.01ms
preact-hooks0.83ms - 0.83msslower ❌
2% - 2%
0.01ms - 0.01ms		slower ❌
2% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master52.85ms - 54.55ms-unsure 🔍
-2% - +1%
-1.32ms - +0.46ms		faster ✔
1% - 4%
0.53ms - 2.34ms
preact-local53.86ms - 54.40msunsure 🔍
-1% - +2%
-0.46ms - +1.32ms		-faster ✔
1% - 3%
0.60ms - 1.42ms
preact-hooks54.83ms - 55.45msslower ❌
1% - 4%
0.53ms - 2.34ms		slower ❌
1% - 3%
0.60ms - 1.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.07ms - 1.07ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.02ms
preact-local1.07ms - 1.07msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.02ms
preact-hooks1.09ms - 1.09msslower ❌
2% - 2%
0.02ms - 0.02ms		slower ❌
2% - 2%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks
@github-actions
Copy link

github-actions bot commented Mar 31, 2023 •
edited
Loading

Size Change: +250 B (0%)

Total Size: 54.6 kB

Filename Size Change
dist/preact.js 4.25 kB +41 B (0%)
dist/preact.min.js 4.28 kB +42 B (0%)
dist/preact.min.module.js 4.28 kB +42 B (0%)
dist/preact.min.umd.js 4.31 kB +42 B (0%)
dist/preact.module.js 4.27 kB +40 B (0%)
dist/preact.umd.js 4.32 kB +43 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.91 kB 0 B
compat/dist/compat.module.js 3.84 kB 0 B
compat/dist/compat.umd.js 3.98 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.61 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action
@andrewiggins andrewiggins force-pushed the support-comment-vnodes branch from 56a251c to 487adfe Compare March 31, 2023 09:07
@coveralls
Copy link

coveralls commented Mar 31, 2023 •
edited
Loading

Coverage Status

Coverage: 99.551% (+0.003%) from 99.548% when pulling 487adfe on support-comment-vnodes into 4f2af1c on master.
@andrewiggins andrewiggins marked this pull request as ready for review April 3, 2023 20:03
@andrewiggins andrewiggins marked this pull request as draft April 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@andrewiggins @coveralls @Thompson1985