Skip to content

Migrate v10.x dependency management to pnpm - #5128

Open
andrewiggins wants to merge 4 commits into
v10.xfrom
chore/v10-pnpm-migration
Open

Migrate v10.x dependency management to pnpm#5128
andrewiggins wants to merge 4 commits into
v10.xfrom
chore/v10-pnpm-migration

Conversation

@andrewiggins

@andrewiggins andrewiggins commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • migrate the v10.x branch from npm package-lock files to a pnpm workspace and committed pnpm-lock.yaml
  • update package scripts, Husky, docs, and CI workflows to install/cache/run/pack with pnpm
  • keep npm publishing behavior intact while matching PR Migrate dependency management to pnpm #5085's pnpm 11 and Node 24 toolchain policy

Verification

  • pnpm --version -> 11.1.0
  • pnpm install --frozen-lockfile
  • pnpm run lint
  • Used a temporary change to src to verify benchmmark and size action still passes

Notes

  • pnpm run test:unit was attempted, but this Codespaces host is missing Playwright browser system libraries (libatk, libxcomposite, libgbm, libasound, etc.), so the browser portion cannot launch here.

GPT 5.5 was used to generate some parts of this PR
@github-actions

github-actions Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-2.85ms - +7.36ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.03ms - +0.10ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +3% (-1.35ms - +1.64ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +3% (-0.15ms - +0.41ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.45ms - +0.67ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +9% (-0.00ms - +0.18ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.40ms - +0.46ms)
    preact-local vs preact-main
  • update10th1k: slower ❌ 1% - 6% (0.47ms - 1.94ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +3% (-0.17ms - +0.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +3% (-0.04ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local833.34ms - 841.58ms-unsure 🔍
-0% - +1%
-2.85ms - +7.36ms
preact-main832.19ms - 838.22msunsure 🔍
-1% - +0%
-7.36ms - +2.85ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.21ms - 19.21ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.21ms - 19.21msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.56ms - 16.67ms-unsure 🔍
-0% - +1%
-0.03ms - +0.10ms
preact-main16.56ms - 16.61msunsure 🔍
-1% - +0%
-0.10ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.56ms - 1.57ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.56ms - 1.57msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.40ms - 62.47ms-unsure 🔍
-2% - +3%
-1.35ms - +1.64ms
preact-main60.21ms - 62.36msunsure 🔍
-3% - +2%
-1.64ms - +1.35ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.01ms - 5.26ms-unsure 🔍
-3% - +3%
-0.17ms - +0.17ms
preact-main5.01ms - 5.25msunsure 🔍
-3% - +3%
-0.17ms - +0.17ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.31ms - 16.75ms-unsure 🔍
-1% - +3%
-0.15ms - +0.41ms
preact-main16.23ms - 16.57msunsure 🔍
-2% - +1%
-0.41ms - +0.15ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.73ms - 3.74ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.73ms - 3.73msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5602

  • Commit: 637c7be

duration

VersionAvg timevs preact-localvs preact-main
preact-local57.21ms - 58.55ms-unsure 🔍
-2% - +1%
-1.45ms - +0.67ms
preact-main57.45ms - 59.09msunsure 🔍
-1% - +3%
-0.67ms - +1.45ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.02ms - 3.02ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.02ms - 3.02msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local26.92ms - 27.63ms-unsure 🔍
-1% - +2%
-0.39ms - +0.60ms
preact-main26.83ms - 27.51msunsure 🔍
-2% - +1%
-0.60ms - +0.39ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.56ms - 32.38ms-unsure 🔍
-2% - +2%
-0.55ms - +0.61ms
preact-main31.53ms - 32.35msunsure 🔍
-2% - +2%
-0.61ms - +0.55ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local31.50ms - 32.58ms-unsure 🔍
-4% - +1%
-1.15ms - +0.43ms
preact-main31.83ms - 32.97msunsure 🔍
-1% - +4%
-0.43ms - +1.15ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.41ms - 27.45ms-unsure 🔍
-0% - +4%
-0.10ms - +1.04ms
preact-main26.23ms - 26.69msunsure 🔍
-4% - +0%
-1.04ms - +0.10ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.41ms - 23.25ms-unsure 🔍
-4% - +1%
-1.00ms - +0.27ms
preact-main22.72ms - 23.67msunsure 🔍
-1% - +4%
-0.27ms - +1.00ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.55ms - 21.94ms-unsure 🔍
-1% - +2%
-0.33ms - +0.34ms
preact-main21.46ms - 22.00msunsure 🔍
-2% - +1%
-0.34ms - +0.33ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #5602

  • Commit: 637c7be

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.08ms - 2.20ms-unsure 🔍
-0% - +9%
-0.00ms - +0.18ms
preact-main1.98ms - 2.12msunsure 🔍
-9% - +0%
-0.18ms - +0.00ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.02ms - 1.07ms-unsure 🔍
-4% - +3%
-0.04ms - +0.03ms
preact-main1.03ms - 1.08msunsure 🔍
-3% - +4%
-0.03ms - +0.04ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.77ms - 35.31ms-unsure 🔍
-1% - +1%
-0.40ms - +0.46ms
preact-main34.67ms - 35.35msunsure 🔍
-1% - +1%
-0.46ms - +0.40ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.26ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.26ms - 1.26msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k
  • Browser: chrome-headless
  • Sample size: 130
  • Built by: CI #5602

  • Commit: 637c7be

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.99ms - 34.06ms-slower ❌
1% - 6%
0.47ms - 1.94ms
preact-main31.82ms - 32.83msfaster ✔
1% - 6%
0.47ms - 1.94ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 3.00ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-

tachometer-reporter-action v2 for CI
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 79.6 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.22 kB
compat/dist/compat.mjs 4.14 kB
compat/dist/compat.module.js 4.14 kB
compat/dist/compat.umd.js 4.28 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.83 kB
dist/preact.min.js 4.85 kB
dist/preact.min.module.js 4.86 kB
dist/preact.min.umd.js 4.87 kB
dist/preact.mjs 4.86 kB
dist/preact.module.js 4.86 kB
dist/preact.umd.js 4.88 kB
hooks/dist/hooks.js 1.51 kB
hooks/dist/hooks.mjs 1.54 kB
hooks/dist/hooks.module.js 1.54 kB
hooks/dist/hooks.umd.js 1.58 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action
@andrewiggins
andrewiggins marked this pull request as ready for review June 30, 2026 04:15
JoviDeCroock
JoviDeCroock reviewed Jul 1, 2026
View reviewed changes
Comment thread .github/workflows/build-test.yml
@andrewiggins andrewiggins changed the title [codex] Migrate v10.x dependency management to pnpm Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@andrewiggins @JoviDeCroock