test(registry): Add goleak-based goroutine leak detection - #1797
Merged
Conversation
surinkim
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
April 13, 2025 14:56
surinkim
force-pushed
the
test/registry-goleak
branch
from
April 13, 2025 15:02
7f02cb1 to
44b3d1e
Compare
Signed-off-by: hyunuk <nnhope@hotmail.com>
surinkim
force-pushed
the
test/registry-goleak
branch
from
April 13, 2025 15:15
44b3d1e to
2ac28a9
Compare
bwplotka
approved these changes
Apr 24, 2025
bwplotka
left a comment
bwplotka
left a comment
Member
There was a problem hiding this comment.
Generally LGTM -- was there any historical leak that trigger this PR?
One thing to ensure -- does this upset client_golang importers in terms of extra dependency. I assume NO given we only import this in test, importers should not see it (in theory).
Member
|
Thanks! |
juliusmh
pushed a commit
to juliusmh/client_golang
that referenced
this pull request
Jun 30, 2025
…#1797) Signed-off-by: hyunuk <nnhope@hotmail.com>
1 task
1 task
1 task
1 task
1 task
1 task
Merged
1 task
1 task
1 task
1 task
Merged
1 task
1 task
This was referenced Jul 19, 2026
Open
This was referenced Jul 21, 2026
1 task
This was referenced Jul 24, 2026
Open
This was referenced Jul 25, 2026
This was referenced Jul 26, 2026
This was referenced Aug 1, 2026
fix(deps): update module github.com/prometheus/client_golang to v1.24.1
jabrown93/apcupsd-exporter#4
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(registry): Add goleak-based goroutine leak detection test for Registry.Gather
This commit adds a new test case
TestGatherDoesNotLeakGoroutineswhich verifies that repeated calls toRegistry.Gather()do not leak goroutines.Gather()is called 1000 timesgoleak.VerifyNoneensures that no unexpected goroutines remainThis test serves as a future safeguard to detect goroutine leaks under heavy usage.