Merged
Conversation
- Add MontyObject::NamedTuple variant for named tuple representation - Add StatMode and StatPerms structs for ergonomic file mode creation - Add file_stat, dir_stat, symlink_stat builders in os.rs - Add stat_result field names to StaticStrings - Update os_tests.rs with round-trip tests using new API - Add NamedTuple handling to JS and Python converters Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Instead of converting NamedTuple to a plain tuple, now creates a proper Python namedtuple type using collections.namedtuple(type_name, field_names) and instantiates it with the values. This preserves named field access. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 4ab2871.
Use raw i64 mode values instead of wrapper types. The file_stat, dir_stat, and symlink_stat functions now document common permission values like 0o644 and 0o755. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Allows handling OS calls (Path.exists, Path.stat, etc.) synchronously in run() via a callback, instead of requiring start/resume flow. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
!reviewfast |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement sandboxed filesystem access through Python's
pathlibmodule. The design uses:stat(),exists(),read_bytes()- passed asimpl OsAccessgenericOsAccessimplementation