Fix failing CI on main#11237
Merged
jsignell merged 2 commits intopydata:mainfrom Mar 17, 2026
Merged
Conversation
Member
Author
|
@chuckwondo do you think this is the right fix? |
Contributor
|
Good question. Based upon the changelog entry, I'm wondering if we simply want to drop the removed flag rather than replace it with the new flag. Since the new flag is intended to restore the behavior of the removed flag, I'm thinking we might not want to do that since, "Errors are now ignored in site-packages by default." |
Member
Author
|
You are a better reader than me! I think you are 100% right |
Member
Author
|
Is someone available to approve this? Maybe @keewis or @VeckoTheGecko? |
dcherian
approved these changes
Mar 17, 2026
Contributor
|
In general, anyone with merge rights should feel empowered to click the green button based on their personal judgement of risks involved. We all trust your judgement! And in the rare event that the PR is flawed, reverts are cheap and easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing on main with errors like:
This PR
changesremoves "mypy-only-local-stub"to "mypy-no-silence-site-packages"because it feels like what we are seeing is probably https://github.com/typeddjango/pytest-mypy-plugins/blob/4.0.0/CHANGELOG.md?plain=1#L7-L9