Skip to content

Fix failing CI on main#11237

Merged
jsignell merged 2 commits intopydata:mainfrom
jsignell:fix-ci
Mar 17, 2026
Merged

Fix failing CI on main#11237
jsignell merged 2 commits intopydata:mainfrom
jsignell:fix-ci

Conversation

@jsignell
Copy link
Copy Markdown
Member

@jsignell jsignell commented Mar 16, 2026

CI is failing on main with errors like:

ERROR: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: unrecognized arguments: --mypy-only-local-stub
  inifile: /home/runner/work/xarray/xarray/pyproject.toml
  rootdir: /home/runner/work/xarray/xarray

This PR changes removes "mypy-only-local-stub" to "mypy-no-silence-site-packages" because it feels like what we are seeing is probably https://github.com/typeddjango/pytest-mypy-plugins/blob/4.0.0/CHANGELOG.md?plain=1#L7-L9

@jsignell
Copy link
Copy Markdown
Member Author

@chuckwondo do you think this is the right fix?

@chuckwondo
Copy link
Copy Markdown
Contributor

Good question. Based upon the changelog entry, I'm wondering if we simply want to drop the removed flag rather than replace it with the new flag. Since the new flag is intended to restore the behavior of the removed flag, I'm thinking we might not want to do that since, "Errors are now ignored in site-packages by default."

@jsignell
Copy link
Copy Markdown
Member Author

You are a better reader than me! I think you are 100% right

@jsignell
Copy link
Copy Markdown
Member Author

Is someone available to approve this? Maybe @keewis or @VeckoTheGecko?

@dcherian
Copy link
Copy Markdown
Contributor

In general, anyone with merge rights should feel empowered to click the green button based on their personal judgement of risks involved. We all trust your judgement! And in the rare event that the PR is flawed, reverts are cheap and easy.

@jsignell jsignell merged commit 99769c2 into pydata:main Mar 17, 2026
41 checks passed
@jsignell jsignell deleted the fix-ci branch March 17, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants