Skip to content

Drop support for EOL Python 2.6#25

Merged
vtitor merged 6 commits into
pytest-dev:masterfrom
hugovk:rm-2.6
Mar 12, 2018
Merged

Drop support for EOL Python 2.6#25
vtitor merged 6 commits into
pytest-dev:masterfrom
hugovk:rm-2.6

Conversation

@hugovk

@hugovk hugovk commented Mar 12, 2018

Copy link
Copy Markdown
Member

pytest itself has already dropped support for Python 2.6 (in pytest-dev/pytest#2812) as it's been EOL for over four years.

This drops support for Python 2.6 and updates some code to make use of new Python 2.7+ features.

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugovk! 😁

Comment thread tox.ini Outdated
py26: pytest<3.3
py{27,34,35,36}: pytest
py26: twisted<15.5
py{27,34,35,36}: twisted

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both pytest and twisted dependencies, remove the py{27,34,35,36}: . It's great I just learned how to make this work in time for py26 support to be removed. :]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) Done!

Comment thread README.rst

.. |Pythons| image:: https://img.shields.io/pypi/pyversions/pytest-twisted.svg
:alt: supported Python versions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure quite what is wrong but these badges don't seem to be loading properly.

https://github.com/hugovk/pytest-twisted/blob/44e308c15510c878b4de2a86e4bd66cbc177550e/README.rst
image

Maybe it's just a temporary issue and not a source bug? I don't know.

@hugovk hugovk Mar 12, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a temporary problem with shields.io, I saw this on another repo too. And someone just reported this to shields.io a few minutes ago:

badges/shields#1568

Would you rather these left out for now, or wait a bit longer?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, leave it. Maybe update all to the :target: form though? I have little experience with rst and wasn't aware of that. Definitely seems better though.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! :alt: and :target: for all.

@altendky

Copy link
Copy Markdown
Member

@hugovk thanks for the tweaks. :]

@vtitor vtitor merged commit d62fc64 into pytest-dev:master Mar 12, 2018
@vtitor

vtitor commented Mar 12, 2018

Copy link
Copy Markdown
Member

@hugovk Awesome, thanks.

@hugovk hugovk deleted the rm-2.6 branch March 12, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants