feat: add mkdocs-material schema to catalog#324
feat: add mkdocs-material schema to catalog#324skwde wants to merge 1 commit intopython-jsonschema:mainfrom
Conversation
|
👍 looks good! I'll need to run some jobs to generate configs from this, so I'll circle back to do that and merge (unless I run into any issues) later today or this week at the latest. |
|
Okay, unfortunately, there's a bit of a problem with this addition, so it won't be a trivial merge (as some of the other schemas have been). I took this branch and trialed merging to It turns out, the I'm going to need to reach out the mkdocs maintainers and see what kind of resolution seems appropriate. We can vendor all referenced schemas today and try to work that way, but I'd like to check with them before taking such a drastic measure. |
|
Ohh, that is unfortunate. I don't really mind which branch we continue to use. In case I can help somehow. I can also work on your new branch. |
|
Just FYI, this problem is, it turns out, worse than I thought. I opened a discussion to ask for the mkdocs-material maintainers' advice and input. The result is pushing me to reconsider trying to do this. The fact that we have to account for those 3rd party schemas somehow, and that they might not even be a complete definition of the file's contents, makes me pretty nervous. I'm going to keep chewing on this, and I'll get involved if mkdocs-material is open to producing an inlined variant of their schema. But for the moment I'm sort of putting this feature on the shelf -- too many open questions and difficult problems. |
|
I'm closing this, as I don't think it's likely to happen without some changes on the mkdocs-material side, which I'm not sure they want to or even should make. The discussion linked above has a lot more details for anyone curious. Basically, we want different things out of the single schema and I don't see a way to make their schema (which IMO is theirs to maintain as they see fit) meet the requirements of a pre-commit hook. I greatly appreciate the effort and initiative shown in opening this PR! But closing is the best/clearest outcome in this case. |
Schema json for MkDocs Material (https://github.com/squidfunk/mkdocs-material)
See https://squidfunk.github.io/mkdocs-material/creating-your-site/ for filename and schema link.