gh-111178: Avoid calling functions from incompatible pointer types in descrobject.c by chrstphrchvz · Pull Request #112861 · python/cpython

chrstphrchvz · 2023-12-08T04:03:56Z

Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Objects/descrobject.c:1913:5: warning: cast from 'void (*)(mappingproxyobject *)' to 'destructor' (aka 'void (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 1913 | (destructor)mappingproxy_dealloc, /* tp_dealloc */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan error: Python/generated_cases.c.h:3315:13: runtime error: call to function mappingproxy_dealloc through pointer to incorrect function type 'void (*)(struct _object *)' descrobject.c:1160: note: mappingproxy_dealloc defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Python/generated_cases.c.h:3315:13 in

Objects/descrobject.c:808:5: warning: cast from 'PyObject *(*)(PyMemberDescrObject *, PyObject *, PyObject *)' (aka 'struct _object *(*)(PyMemberDescrObject *, struct _object *, struct _object *)') to 'descrgetfunc' (aka 'struct _object *(*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 808 | (descrgetfunc)member_get, /* tp_descr_get */ | ^~~~~~~~~~~~~~~~~~~~~~~~ Objects/descrobject.c:809:5: warning: cast from 'int (*)(PyMemberDescrObject *, PyObject *, PyObject *)' (aka 'int (*)(PyMemberDescrObject *, struct _object *, struct _object *)') to 'descrsetfunc' (aka 'int (*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 809 | (descrsetfunc)member_set, /* tp_descr_set */ | ^~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan error: Objects/object.c:1682:19: runtime error: call to function member_set through pointer to incorrect function type 'int (*)(struct _object *, struct _object *, struct _object *)' descrobject.c:227: note: member_set defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/object.c:1682:19 in Objects/object.c:1564:19: runtime error: call to function member_get through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *, struct _object *)' descrobject.c:160: note: member_get defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/object.c:1564:19 in

Example compiler warning: Objects/descrobject.c:703:5: warning: cast from 'void (*)(PyDescrObject *)' to 'destructor' (aka 'void (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 703 | (destructor)descr_dealloc, /* tp_dealloc */ | ^~~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan error: Objects/object.c:2857:5: runtime error: call to function descr_dealloc through pointer to incorrect function type 'void (*)(struct _object *)' descrobject.c:23: note: descr_dealloc defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/object.c:2857:5 in

Objects/descrobject.c:771:5: warning: cast from 'PyObject *(*)(PyMethodDescrObject *, PyObject *, PyObject *)' (aka 'struct _object *(*)(PyMethodDescrObject *, struct _object *, struct _object *)') to 'descrgetfunc' (aka 'struct _object *(*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 771 | (descrgetfunc)classmethod_get, /* tp_descr_get */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan error: Objects/typeobject.c:10293:24: runtime error: call to function classmethod_get through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *, struct _object *)' descrobject.c:94: note: classmethod_get defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/typeobject.c:10293:24 in

Objects/descrobject.c:845:5: warning: cast from 'PyObject *(*)(PyGetSetDescrObject *, PyObject *, PyObject *)' (aka 'struct _object *(*)(PyGetSetDescrObject *, struct _object *, struct _object *)') to 'descrgetfunc' (aka 'struct _object *(*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 845 | (descrgetfunc)getset_get, /* tp_descr_get */ | ^~~~~~~~~~~~~~~~~~~~~~~~ Objects/descrobject.c:846:5: warning: cast from 'int (*)(PyGetSetDescrObject *, PyObject *, PyObject *)' (aka 'int (*)(PyGetSetDescrObject *, struct _object *, struct _object *)') to 'descrsetfunc' (aka 'int (*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 846 | (descrsetfunc)getset_set, /* tp_descr_set */ | ^~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan error: Objects/typeobject.c:4861:19: runtime error: call to function getset_get through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *, struct _object *)' descrobject.c:180: note: getset_get defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/typeobject.c:4861:19 in

Objects/descrobject.c:739:5: warning: cast from 'PyObject *(*)(PyMethodDescrObject *, PyObject *, PyObject *)' (aka 'struct _object *(*)(PyMethodDescrObject *, struct _object *, struct _object *)') to 'descrgetfunc' (aka 'struct _object *(*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 739 | (descrgetfunc)method_get, /* tp_descr_get */ | ^~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan error: Objects/object.c:1621:15: runtime error: call to function method_get through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *, struct _object *)' descrobject.c:138: note: method_get defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/object.c:1621:15 in

Objects/descrobject.c

…pes in descrobject.c (pythonGH-112861) Fix undefined behavior warnings (UBSan -fsanitize=function), for example: Python/generated_cases.c.h:3315:13: runtime error: call to function mappingproxy_dealloc through pointer to incorrect function type 'void (*)(struct _object *)' descrobject.c:1160: note: mappingproxy_dealloc defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Python/generated_cases.c.h:3315:13 in

chrstphrchvz added 30 commits December 7, 2023 22:01

Make method_repr() compatible with reprfunc

eb6c22e

Make classmethoddescr_call() compatible with ternaryfunc

60c0d7a

Make getset_repr() compatible with reprfunc

1de5a1a

Make member_repr() compatible with reprfunc

8b57573

Make wrapperdescr_repr() compatible with reprfunc

d2f06e6

Make wrapperdescr_call() compatible with ternaryfunc

4cd2e6d

Make wrapper_repr() compatible with reprfunc

f32c9e0

Make wrapper_reduce() compatible with PyCFunction

83df0df

Make wrapper_hash() compatible with hashfunc

a4c7f17

Make wrapper_dealloc() compatible with destructor

be0fb74

Make wrapper_objclass() compatible with getter

356c2fe

Make wrapper_name() compatible with getter

ec4ca04

Make wrapper_qualname() compatible with getter

9ebb68f

Make wrapper_text_signature() compatible with getter

de99189

Make wrapper_doc() compatible with getter

9b43a8d

mappingproxy_dealloc(): less inconsistent parameter name

32b8dfe

descr_dealloc(): less inconsistent parameter name

78419d6

Make mappingproxy_getiter() compatible with getiterfunc

97d3ee8

Make mappingproxy_hash() compatible with hashfunc

30cd173

Make mappingproxy_str() compatible with reprfunc

fcce565

Make mappingproxy_repr() compatible with reprfunc

776acd7

Make mappingproxy_richcompare() compatible with richcmpfunc

f4dfb12

Remove redundant cast of property_clear()

80da821

Make mappingproxy_contains() compatible with objobjproc

7b903ea

chrstphrchvz added 17 commits December 7, 2023 22:02

Make wrapper_call() compatible with ternaryfunc

d646a9d

Make mappingproxy_reversed() compatible with PyCFunction

75a4980

Make mappingproxy_copy() compatible with PyCFunction

e96377d

Make mappingproxy_items() compatible with PyCFunction

0002cba

Make mappingproxy_values() compatible with PyCFunction

057c059

Make mappingproxy_keys() compatible with PyCFunction

57224d0

Make mappingproxy_getitem() compatible with binaryfunc

071d2bc

Make mappingproxy_len() compatible with lenfunc

65f0a90

Make method_get_doc() compatible with getter

385dbfd

Make descr_get_qualname() compatible with getter

a0e0ae0

Make method_get_text_signature() compatible with getter

ff534a1

Make member_get_doc() compatible with getter

ae28dc1

Make getset_get_doc() compatible with getter

547cbc0

Make wrapperdescr_get_doc() compatible with getter

6360a46

Make wrapperdescr_get_text_signature() compatible with getter

e823bed

Make wrapperdescr_get() compatible with descrgetfunc

6c15c76

Make descr_reduce() compatible with PyCFunction

238724f

bedevere-app bot added the awaiting review label Dec 8, 2023

bedevere-app bot mentioned this pull request Dec 8, 2023

UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Closed

chrstphrchvz commented Dec 8, 2023

View reviewed changes

Objects/descrobject.c Outdated Show resolved Hide resolved

chrstphrchvz added 2 commits December 8, 2023 02:23

Need to update type in cast

cb6f751

Make mappingproxy_get() compatible with _PyCFunctionFast

dd64280

encukou added the skip news label Jan 2, 2024

encukou merged commit acf4cf5 into python:main Jan 2, 2024

bedevere-app bot removed the awaiting review label Jan 2, 2024

chrstphrchvz deleted the patch-111178-descrobject branch January 2, 2024 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-111178: Avoid calling functions from incompatible pointer types in descrobject.c#112861

gh-111178: Avoid calling functions from incompatible pointer types in descrobject.c#112861
encukou merged 49 commits intopython:mainfrom
chrstphrchvz:patch-111178-descrobject

chrstphrchvz commented Dec 8, 2023 •

edited by bedevere-app bot

Loading

Uh oh!

Labels

2 participants

Uh oh!

Conversation

chrstphrchvz commented Dec 8, 2023 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Labels

2 participants

chrstphrchvz commented Dec 8, 2023 •

edited by bedevere-app bot

Loading