Skip to content

gh-124513: Check args in framelocalsproxy_new() - #124515

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:framelocalsproxy
Sep 25, 2024
Merged

gh-124513: Check args in framelocalsproxy_new()#124515
vstinner merged 3 commits into
python:mainfrom
vstinner:framelocalsproxy

Conversation

@vstinner

@vstinner vstinner commented Sep 25, 2024

Copy link
Copy Markdown
Member

Fix a crash in FrameLocalsProxy constructor: check the number of arguments.

Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
Comment thread Objects/frameobject.c
@vstinner

Copy link
Copy Markdown
Member Author

Something is wrong on the CI:

  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +8dbbba75ce565586fbe5e0b9325a3f7113f31c88:refs/remotes/pull/124515/merge
  remote: git: 'lariat' is not a git command. See 'git --help'.        
  remote: aborting due to possible repository corruption on the remote side.
  Error: fatal: protocol error: bad pack header
  The process '/usr/bin/git' failed with exit code 128
  Waiting 12 seconds before trying again
@vstinner vstinner closed this Sep 25, 2024
@vstinner vstinner reopened this Sep 25, 2024
@vstinner

Copy link
Copy Markdown
Member Author

Close/reopen to trigger a new CI job.

Comment thread Objects/frameobject.c
@vstinner
vstinner merged commit d6954b6 into python:main Sep 25, 2024
@vstinner
vstinner deleted the framelocalsproxy branch September 25, 2024 19:41
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Sep 25, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
(cherry picked from commit d6954b6)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

GH-124539 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 25, 2024
@vstinner

Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @JelleZijlstra.

emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull request Sep 26, 2024
* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in framelocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
…124539)

gh-124513: Check args in framelocalsproxy_new() (GH-124515)

Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
(cherry picked from commit d6954b6)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants