Skip to content

gh-126374: Add support of options with optional arguments in the getopt module#126375

Merged
serhiy-storchaka merged 5 commits intopython:mainfrom
serhiy-storchaka:getopt-optional
Nov 11, 2024
Merged

gh-126374: Add support of options with optional arguments in the getopt module#126375
serhiy-storchaka merged 5 commits intopython:mainfrom
serhiy-storchaka:getopt-optional

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 3, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 3, 2024
Closed
brianschubert
brianschubert reviewed Nov 3, 2024
View reviewed changes
@serhiy-storchaka @brianschubert
Apply suggestions from code review
3105620 
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Nov 4, 2024

Thank you for your suggestions @brianschubert.
erlend-aasland
erlend-aasland reviewed Nov 4, 2024
View reviewed changes
@serhiy-storchaka @erlend-aasland
Update Doc/library/getopt.rst
efc63db 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 6, 2024
Merged
serhiy-storchaka
serhiy-storchaka commented Nov 7, 2024
View reviewed changes
@serhiy-storchaka serhiy-storchaka merged commit 25aee21 into python:main Nov 11, 2024
@serhiy-storchaka serhiy-storchaka deleted the getopt-optional branch November 11, 2024 16:29
@brianschubert
Copy link
Contributor

brianschubert commented Nov 13, 2024

Sorry if I'm missing some context, but since this is a new feature, shouldn't it have gotten at least one green-check review before being merged?

Per Workflow change coming: mandatory reviews on new features
@gpshead gpshead added the type-feature A feature request or enhancement label Nov 13, 2024
@gpshead
Copy link
Member

gpshead commented Nov 13, 2024

Sorry if I'm missing some context, but since this is a new feature, shouldn't it have gotten at least one green-check review before being merged?

Technically yes. Our automation cannot detect and label such things accurately. LGTM on this change. For what its worth I had seen these changes as part of #126393 (which was stacked on top of this) prior to this and was happy with them; Serhiy answered a question I had left there on what turned out to be this PRs changes. we just hadn't connected all the dots to make that obvious on github.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@serhiy-storchaka @picnixz
pythongh-126374: Add support of options with optional arguments in th…
de49afc 
…e getopt module (pythonGH-126375)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@serhiy-storchaka @ebonnal
pythongh-126374: Add support of options with optional arguments in th…
f41632c 
…e getopt module (pythonGH-126375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

4 participants

@serhiy-storchaka @brianschubert @gpshead @erlend-aasland