Skip to content

gh-143919: Reject control characters in http cookies #143920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmlarson merged 5 commits into from
Jan 20, 2026
Merged

gh-143919: Reject control characters in http cookies #143920

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef01008
Add 'test.support' fixture for C0 control characters
sethmlarson Jan 16, 2026
fdbf0c4
gh-143919: Reject control characters in http.cookies.Morsel
sethmlarson Jan 8, 2026
03f222d
Apply suggestions from code review
sethmlarson Jan 16, 2026
6b999b5
Apply suggestions from code review
sethmlarson Jan 16, 2026
216e492
Fix doctest
sethmlarson Jan 20, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
  • Loading branch information
@sethmlarson @johnslavik
sethmlarson and johnslavik authored Jan 16, 2026
commit 03f222d8808552582b69bfd2da7266b2a5573df6
1 change: 0 additions & 1 deletion Lib/test/test_http_cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,6 @@ def test_control_characters_output(self):
cookie.output()

Comment thread
sethmlarson marked this conversation as resolved.


def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite(cookies))
return tests
Expand Down
Loading