Uses windowed setting in shebang processing to avoid using the console. - #254
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for a windowed parameter to shebang processing, allowing scripts to be launched with GUI-mode executables instead of console executables on Windows. This addresses issue #216 by enabling proper windowed behavior when launching Python scripts.
Changes:
- Added
windowedkeyword-only parameter to shebang processing functions (_find_shebang_command,_parse_shebang,_read_script,find_install_from_script) - Implemented logic to substitute windowed aliases when
windowed=Trueis requested - Updated integration point in
commands.pyto pass the windowed parameter through to script processing - Added comprehensive tests for windowed shebang behavior with 25 new test cases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/manage/scriptutils.py | Added windowed parameter to all shebang processing functions and implemented logic to substitute windowed executables when requested |
| src/manage/commands.py | Updated get_install_to_run to pass windowed parameter to find_install_from_script |
| tests/test_scriptutils.py | Added test data for windowed aliases, new test_read_shebang_windowed test with 25 cases, and updated existing tests to explicitly pass windowed=False |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216