Fix cppcheck missingOverride and functionConst warnings#63913
Merged
Conversation
rouault
force-pushed
the
cppcheck_fixes
branch
2 times, most recently
from
6f9cc7b to
e55871e
Compare
nyalldawson
reviewed
Nov 12, 2025
rouault
force-pushed
the
cppcheck_fixes
branch
from
e55871e to
a188fb2
Compare
nyalldawson
approved these changes
Nov 12, 2025
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
rouault
force-pushed
the
cppcheck_fixes
branch
from
a188fb2 to
c410d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few remaining functionConst warnings but there are false positives (typically setter functions with empty implementation). While investing that, I've found a few occurrences where they could be safely removed