Skip to content

[Backport queued_ltr_backports] Fix relation reference field formatter type mismatch - #66436

Closed
qgis-bot wants to merge 17 commits into
queued_ltr_backportsfrom
backport-66392-to-queued_ltr_backports
Closed

[Backport queued_ltr_backports] Fix relation reference field formatter type mismatch#66436
qgis-bot wants to merge 17 commits into
queued_ltr_backportsfrom
backport-66392-to-queued_ltr_backports

Conversation

@qgis-bot

@qgis-bot qgis-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Backport #66392
Authored by: @elpaso
elpaso and others added 16 commits May 31, 2026 08:00
@elpaso @nyalldawson
Vector legend : fix count when ELSE rule
108cb88 
Maybe fix #52690
@gacarrillor @nyalldawson
[fix] Add missing SIP_OUT to QgsVectorLayer::deleteSelectedFeatures()
eeff921
@nyalldawson
Sipify
daf3b84
@j-pallas @nyalldawson
Update oarec_service_metadata.html
78045fa 
only one request to /collections
@agiudiceandrea @nyalldawson
[processing] Fix native:checkgeometryhole gc_layername value
3479bd2
@ViperMiniQ @nyalldawson
fix circularstring deletevertex removing geometry when n=3 on invalid…
44381ff 
… vertexid
@ViperMiniQ @nyalldawson
invert asssert logic
7889886
@nyalldawson
Apply suggestion from @nyalldawson
e80c9cd
@ViperMiniQ @nyalldawson
do not decrease value reference count twice
433a7c4
@nyalldawson
Sipify
3456d3b
@nilason @github-actions
Fix GRASS installedVersion check for GRASS 8.5
8c3bead 
With GRASS 8.5 the project name is rebranded, dropping 'GIS' from the name,
thus the parsing of the version fails and make the processing tools unavailable.
@alexbruy
Merge pull request #66290 from qgis/backport-66256-to-queued_ltr_back…
987a039 
…ports

[Backport queued_ltr_backports] Fix GRASS installedVersion check for GRASS 8.5
@alexbruy
Merge pull request #66265 from qgis/backport-66248-to-queued_ltr_back…
5a03599 
…ports

[Backport queued_ltr_backports] Fix QgsLineString SIP code
@elpaso @github-actions
Fix relation reference field formatter type mismatch
40ded14 
Fix #66339
@elpaso @nyalldawson @github-actions
Update src/core/fieldformatter/qgsrelationreferencefieldformatter.cpp
d7b14a2 
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
@elpaso @github-actions
check convert
b698c57
@github-actions github-actions Bot added this to the 3.44.13 milestone Jun 10, 2026
nyalldawson
nyalldawson reviewed Jun 12, 2026
View reviewed changes
Comment thread tests/src/core/testqgsrelationreferencefieldformatter.cpp Outdated
Comment thread tests/src/core/testqgsrelationreferencefieldformatter.cpp Outdated
@nyalldawson
Apply suggestions from code review
a36dbba 
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
nyalldawson
nyalldawson reviewed Jun 15, 2026
View reviewed changes
Comment thread src/core/fieldformatter/qgsrelationreferencefieldformatter.cpp
if ( keyType != cacheKeyType && value.canConvert( cacheKeyType ) )
{
QVariant key = value;
if ( key.convert( cacheKeyType ) )

@nyalldawson nyalldawson Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elpaso something needs fixing here -- this line is breaking the qt5 build
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.
@github-actions github-actions Bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 30, 2026
@nyalldawson
nyalldawson force-pushed the queued_ltr_backports branch from 841bc80 to aa60ff8 Compare July 4, 2026 21:27
@github-actions github-actions Bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 5, 2026
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.
@github-actions github-actions Bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 20, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.
@github-actions github-actions Bot closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Uh oh! Seems this work is abandoned, and the PR is about to close.

9 participants

@qgis-bot @nyalldawson @elpaso @gacarrillor @j-pallas @agiudiceandrea @ViperMiniQ @nilason @alexbruy