Fix crash on vector tile style parsing

[elpaso]

Fix #66466

[nirvn]

@elpaso , do you feel it'd be worth adding a minimal test to cover this? I've approved as is, I'll let you decide 😉

[elpaso]

@elpaso , do you feel it'd be worth adding a minimal test to cover this? I've approved as is, I'll let you decide 😉

Honestly: it's just an obvious array range check, I wouldn't waste time on a test since there is no risk of someone reverting (besides that I'm not that familiar with the vector style styles).

[qgis-bot]

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1

stderr

error: could not apply 048943a7d75... Fix crash on vector tile style parsing
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

stdout

Auto-merging src/core/vectortile/qgsmapboxglstyleconverter.cpp
CONFLICT (content): Merge conflict in src/core/vectortile/qgsmapboxglstyleconverter.cpp

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-66533-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 048943a7d750a401485e2434ade4d2281e83317a
# Push it to GitHub
git push --set-upstream origin backport-66533-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-66533-to-queued_ltr_backports.