validate custom CRS definition when changing between CRs and warn user about invalid definition (fix #57806) - #66572
Merged
Conversation
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Jun 25, 2026
about invalid definition (fix qgis#57806)
alexbruy
force-pushed
the
custom-crs-validation
branch
from
July 12, 2026 06:22
3749d5b to
7aeb99c
Compare
nyalldawson
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When user changes custom CRS definition to invalid, then selects another custom CRS in the list and returns back to the previously changed CRS, the definition string will be lost.
This is because we update custom CRS definition when current item changes and do not check if CRS created from the definition is valid.
To prevent silent lost of definition we check validity of the CRS, warn user if it is invalid and block changing to another CRS.
Fixes #57806.
AI tool usage