Skip to content

[raster] Fix bad layer properties not saved #66607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyalldawson merged 2 commits into from
Jul 1, 2026
Merged

[raster] Fix bad layer properties not saved #66607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7be6d6
[raster] Fix bad layer properties not saved
elpaso Jun 29, 2026
0cbdcd4
Add null check for brightness filter before setting values
elpaso Jun 30, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/gui/raster/qgsrasterlayerproperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,17 +847,12 @@ void QgsRasterLayerProperties::apply()
}
}

// Do nothing on "bad" layers
if ( !mRasterLayer->isValid() )
return;

// apply all plugin dialogs
for ( QgsMapLayerConfigWidget *page : std::as_const( mConfigWidgets ) )
{
page->apply();
}


/*
* Legend Tab
*/
Expand All @@ -872,9 +867,12 @@ void QgsRasterLayerProperties::apply()
//set whether the layer histogram should be inverted
//mRasterLayer->setInvertHistogram( cboxInvertColorMap->isChecked() );

mRasterLayer->brightnessFilter()->setBrightness( mSliderBrightness->value() );
mRasterLayer->brightnessFilter()->setContrast( mSliderContrast->value() );
mRasterLayer->brightnessFilter()->setGamma( mGammaSpinBox->value() );
if ( mRasterLayer->brightnessFilter() )
{
mRasterLayer->brightnessFilter()->setBrightness( mSliderBrightness->value() );
mRasterLayer->brightnessFilter()->setContrast( mSliderContrast->value() );
mRasterLayer->brightnessFilter()->setGamma( mGammaSpinBox->value() );
}

QgsDebugMsgLevel( u"processing transparency tab"_s, 3 );
/*
Expand Down
Loading