Skip to content

Fix single band grey widget min/max live editing - #66619

Merged
nyalldawson merged 1 commit into
qgis:masterfrom
elpaso:bugfix-gh-65566-doublevalidator-gray-renderer
Jul 1, 2026
Merged

Fix single band grey widget min/max live editing#66619
nyalldawson merged 1 commit into
qgis:masterfrom
elpaso:bugfix-gh-65566-doublevalidator-gray-renderer

Conversation

@elpaso

@elpaso elpaso commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Fix #65566 by not updating the renderer if the values being edited in the widgets are not valid according to the QgsDoubleValidator.

Also fix unreported issues with QgsDoubleValidator not escaping decimal separator and minus sign.

@elpaso elpaso added Rasters Related to general raster layer handling (not specific data formats) GUI/UX Related to QGIS application GUI or User Experience Bug Either a bug report, or a bug fix. Let's hope for the latter! backport queued_ltr_backports Queued Backports labels Jun 30, 2026
@github-actions github-actions Bot added this to the 4.2.0 milestone Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 337dc9c)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
To execute locally, unzip the downloaded zip file and run bin\qgis-bin.exe in the extracted directory.
You might be prompted by Windows Defender click "Run anyway"
(Built from commit 337dc9c)

Fix qgis#65566 by not updating the renderer if the values being edited in
the widgets are not valid according to the QgsDoubleValidator.

Also fix unreported issues with QgsDoubleValidator not not escaping
decimal separator and minus sign.
@elpaso
elpaso force-pushed the bugfix-gh-65566-doublevalidator-gray-renderer branch from 4b35e9a to 337dc9c Compare July 1, 2026 06:28
@nyalldawson
nyalldawson merged commit f7caf96 into qgis:master Jul 1, 2026
27 checks passed
@qgis-bot

qgis-bot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 337dc9c0fe4... Fix single band grey widget min/max live editing
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

stdout
Auto-merging src/gui/qgsdoublevalidator.cpp
CONFLICT (content): Merge conflict in src/gui/qgsdoublevalidator.cpp
Auto-merging src/gui/qgsdoublevalidator.h
Auto-merging src/gui/raster/qgssinglebandgrayrendererwidget.cpp
Auto-merging tests/src/gui/testqgsdoublevalidator.cpp

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-66619-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 337dc9c0fe4b64bdb9d49c4400910d77a13339ca
# Push it to GitHub
git push --set-upstream origin backport-66619-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-66619-to-queued_ltr_backports.

@qgis-bot qgis-bot added the failed backport The automated backport attempt failed, needs a manual backport label Jul 1, 2026
nyalldawson pushed a commit that referenced this pull request Jul 28, 2026
Manual backport of #66619

Fix #65566 by not updating the renderer if the values being edited in
the widgets are not valid according to the QgsDoubleValidator.

Also fix unreported issues with QgsDoubleValidator not not escaping
decimal separator and minus sign.
nyalldawson pushed a commit that referenced this pull request Jul 31, 2026
Manual backport of #66619

Fix #65566 by not updating the renderer if the values being edited in
the widgets are not valid according to the QgsDoubleValidator.

Also fix unreported issues with QgsDoubleValidator not not escaping
decimal separator and minus sign.
nyalldawson pushed a commit that referenced this pull request Aug 1, 2026
Manual backport of #66619

Fix #65566 by not updating the renderer if the values being edited in
the widgets are not valid according to the QgsDoubleValidator.

Also fix unreported issues with QgsDoubleValidator not not escaping
decimal separator and minus sign.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter! failed backport The automated backport attempt failed, needs a manual backport GUI/UX Related to QGIS application GUI or User Experience Rasters Related to general raster layer handling (not specific data formats)

3 participants