[Customization] Reload user defined toolbar actions only one time - #66620
Merged
troopa81 merged 3 commits intoJul 2, 2026
Conversation
It's already done in updateActionVisibility, no need to do it twice
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
Contributor
Author
nyalldawson
reviewed
Jul 1, 2026
signedav
reviewed
Jul 2, 2026
Collaborator
|
Part with the redundant loop makes sense. Maybe add the unrelated icon fix to the PR description or remove it when not part of the implementation. |
Co-authored-by: signedav <david@opengis.ch>
This is part of another fix
Contributor
Author
I removed the setIcon part |
signedav
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix unreported issue: Hidden actions from user defined toolbar are still visible.
It's already done in
updateActionVisibility, we don't need to do it twiceAI tool usage