Skip to content

[Customization] Reload user defined toolbar actions only one time - #66620

Merged
troopa81 merged 3 commits into
qgis:masterfrom
troopa81:fix_customization_hiddenactions_visible
Jul 2, 2026
Merged

[Customization] Reload user defined toolbar actions only one time#66620
troopa81 merged 3 commits into
qgis:masterfrom
troopa81:fix_customization_hiddenactions_visible

Conversation

@troopa81

Copy link
Copy Markdown
Contributor

Description

Fix unreported issue: Hidden actions from user defined toolbar are still visible.

It's already done in updateActionVisibility, we don't need to do it twice

AI tool usage

  • AI tool(s) (Copilot, Claude, or something similar) supported my development of this PR. See our policy about AI tool use. Use of AI tools must be indicated. Failure to be honest might result in banning.
It's already done in updateActionVisibility, no need to do it twice
@github-actions github-actions Bot added this to the 4.2.0 milestone Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
To execute locally, unzip the downloaded zip file and run bin\qgis-bin.exe in the extracted directory.
You might be prompted by Windows Defender click "Run anyway"
(Built from commit 1db7c42)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 1db7c42)

@troopa81 troopa81 closed this Jul 1, 2026
@troopa81 troopa81 reopened this Jul 1, 2026
@troopa81

troopa81 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@signedav Do you mind reviewing ? this a #66483 follow up

Comment thread src/app/qgscustomizationdialog.cpp Outdated
Comment thread tests/src/app/testqgscustomization.cpp Outdated
@signedav

signedav commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Part with the redundant loop makes sense. Maybe add the unrelated icon fix to the PR description or remove it when not part of the implementation.

troopa81 and others added 2 commits July 2, 2026 09:08
Co-authored-by: signedav <david@opengis.ch>
@troopa81

troopa81 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Part with the redundant loop makes sense. Maybe add the unrelated icon fix to the PR description or remove it when not part of the implementation.

I removed the setIcon part

@troopa81
troopa81 merged commit 4ac7d5d into qgis:master Jul 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants