Skip to content

Conversation

@fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 5, 2025

Description

ascii_to_keycode_lut is an array of uint8_t, but apparently I wasn't paying attention when I wrote some of these and used keycodes that were already modified (> 255) here.

There may well be more that have gone unnoticed; for now I'm just fixing these two that were flagged. I'll look into unit tests or at least just going through all of them to make sure they compile - checking the output is correct will be even more tedious.

As noted in linked issue, the rest of the headers work fine, but just to be sure I checked them all myself as well. Still can't speak to whether they output correctly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
@fauxpark fauxpark requested a review from a team October 5, 2025 11:49
@zvecr zvecr merged commit 082b69d into qmk:master Oct 6, 2025
4 checks passed
@fauxpark fauxpark deleted the sendstring-lut-fix-lt-sk branch October 7, 2025 01:28
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 9, 2025
* upstream/master:
  [Keyboard] Add support Tyson65 (qmk#25697)
  Add stardustn0 (qmk#25681)
  add dropout keyboard (qmk#25645)
  Add hnk65 (qmk#25366)
  Add 'xap' branch to CI workflow and options (qmk#25708)
  Add Printronics Mectechpad (qmk#25365)
  Add Keyboard Treasure TYPE-30 (qmk#25688)
  Fix Slovak and Lithuanian (QWERTY) sendstring LUTs (qmk#25703)
  Add FoldKB Rev. 2 (qmk#25679)
  Fix keymap for Palmslave (qmk#25675)
  Update Idyllic pizzapad with Encoder (qmk#25683)
  [Keyboard] Add Quefrency LM Rev. 1 (qmk#25692)
Philanche pushed a commit to Philanche/qmk_firmware that referenced this pull request Oct 20, 2025
hariganti pushed a commit to hariganti/qmk_firmware that referenced this pull request Oct 24, 2025
notchairmk pushed a commit to notchairmk/qmk_firmware that referenced this pull request Oct 24, 2025
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 25, 2025
jcaliz pushed a commit to jcaliz/qmk_firmware that referenced this pull request Oct 29, 2025
Paveun pushed a commit to Paveun/qmk_firmware that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants