Skip to content

Conversation

@nietaki
Copy link

@nietaki nietaki commented Oct 27, 2025

Adding the Revolt rev2 keyboard. I dogfooded the functionality and the default keymap while working on this PR.

The layout for QMK configurator has also been tweaked to resemble the keyboard:

Screenshot 2025-10-27 at 19 02 35

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
@nietaki nietaki requested a review from waffle87 October 28, 2025 00:38
@nietaki
Copy link
Author

nietaki commented Oct 28, 2025

Thank you for the review, @waffle87 🙇

The reasoning behind the suggestions makes sense to me, and I didn't even realise how much you can configure in info/keyboard.json!

@nietaki
Copy link
Author

nietaki commented Oct 29, 2025

Thanks, I didn't spot that in the docs either!

I made sure I didn't mess up the mask (F11 gets picked up by the OS instead of the tester):
Screenshot 2025-10-29 at 18 38 23

@nietaki nietaki requested a review from drashna October 29, 2025 17:41
Comment on lines 21 to 22

#define MATRIX_MASKED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define MATRIX_MASKED
Copy link
Author

@nietaki nietaki Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference (for myself, but maybe also others): The data/mappings/info_config.hjson file looks like the source of truth for all the values that can/should be configured in keyboard.json instead of config.h

edit: that file and data/schemas/keyboard.jsonschema

@nietaki
Copy link
Author

nietaki commented Nov 2, 2025

Thank you, @zvecr, should be all better now.

Thoughts on me making a separate PR to update the docs with the keyboard.json approaches of some of the things I ran into (custom keycodes for example)?

There's not too many examples of some of them in the codebase either, without the docs being updated y'all will probably spend a lot of time giving the same PR feedback for newly added keyboards....

@nietaki nietaki requested a review from zvecr November 2, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants