-
-
Notifications
You must be signed in to change notification settings - Fork 42.9k
Add Revolt (rev2) keyboard #25755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add Revolt (rev2) keyboard #25755
Conversation
|
Thank you for the review, @waffle87 🙇 The reasoning behind the suggestions makes sense to me, and I didn't even realise how much you can configure in |
keyboards/revolt/rev2/config.h
Outdated
|
|
||
| #define MATRIX_MASKED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #define MATRIX_MASKED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference (for myself, but maybe also others): The data/mappings/info_config.hjson file looks like the source of truth for all the values that can/should be configured in keyboard.json instead of config.h
edit: that file and data/schemas/keyboard.jsonschema
|
Thank you, @zvecr, should be all better now. Thoughts on me making a separate PR to update the docs with the There's not too many examples of some of them in the codebase either, without the docs being updated y'all will probably spend a lot of time giving the same PR feedback for newly added keyboards.... |

Adding the Revolt rev2 keyboard. I dogfooded the functionality and the default keymap while working on this PR.
The layout for QMK configurator has also been tweaked to resemble the keyboard:
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist