[CLEAN] Synthetic Benchmark PR #140126 - ESQL: Aggressively free topn#65
Open
bar-qodo wants to merge 1 commit intobase_pr_140126_20260113_4669from
Open
[CLEAN] Synthetic Benchmark PR #140126 - ESQL: Aggressively free topn#65bar-qodo wants to merge 1 commit intobase_pr_140126_20260113_4669from
bar-qodo wants to merge 1 commit intobase_pr_140126_20260113_4669from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR elastic#140126
Type: Clean (correct implementation)
Original PR Title: ESQL: Aggressively free topn
Original PR Description: Without this we free the entire
TopNOperatorand then pitch the reference to it. It'd be best if these two things were atomically locked together, but so long as everything we free is small-ish we can live with keeping the reference for a bit. We reserve some room to maneuver here. But if the thing we're freeing is quite large this ain't great. We think we have room to allocate but we don't.With this we pitch the reference to each row as we go so they can be GCed immediately. This keeps the untracked-but-hard-referenced state to a single row at a time.
Original PR URL: elastic#140126