feat: local native logger and better OOBE - #761
Merged
Conversation
Mac app no longer uses storyboards and directly loads custom webview
quoid
approved these changes
Dec 31, 2024
quoid
left a comment
quoid
left a comment
Owner
There was a problem hiding this comment.
Looks great, I left some feedback regarding the English text, but otherwise, let's get to testing! 
Apply suggestions from code review Co-authored-by: Justin Wasack <7660254+quoid@users.noreply.github.com>
This was referenced Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New local logger helps users debug and obtain logs more easily
It currently only covers the Native App and Extension native parts
That means only covering the Swift part and not the JS part
There is no built-in upload feature, users always need to share logs manually (e.g. attached to an issue)
Mac App no longer uses storyboard, but shares webview with iOS version
Newly designed logger caveats and interactive interface
App webview adds custom I18n implementation and L10n
More friendly OOBE and usage guide for first-time users
Other miscellaneous updates and refactorings
Mac.mp4
iOS.mp4