Merged
Conversation
This adds `fakeroot` and `rpm` to the list of installed packages in the `build-desktop-platforms` GitHub Actions workflow. These are necessary for building RPM packages.
This commit refactors the `build-desktop-platforms.yml` GitHub Actions workflow. Key changes include: * Replacing the manual installation of JDK 21 with the `actions/setup-java@v4` action for better caching and management. * Adding necessary Linux dependencies like `libasound2`, `libgtk-3-0`, and others directly in the `apt-get install` step. * Introducing a step to output logs from `createRuntimeImage` on packaging failure, aiding in debugging build issues. * Removing a redundant `shell: bash` declaration.
Explicitly sets the `shell` to `bash` for the Gradle packaging command in the `build-desktop-platforms.yml` workflow.
This ensures the full JDK, instead of just the JRE, is installed for the desktop build workflow, which is necessary for the build process.
This commit introduces several changes to the `.github/workflows/build-desktop-platforms.yml` GitHub Actions workflow: - Removes the explicit `java-package: 'jdk'` from the Java setup step, as 'jdk' is the default. - Eliminates the Debian container and the manual installation of build dependencies from the `build-linux` job, simplifying the setup. - Removes a command that would output logs for a failed `createRuntimeImage` step, cleaning up the retry logic.
This reverts commit e42818a.
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThe PR updates the GitHub Actions workflow for desktop platform builds. It modifies the macOS build matrix to target different OS versions, replaces the Linux containerized and manual JDK installation approach with a hosted JDK 21 setup action, while leaving the Windows build unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.