feat: use a custom error when items are not files#123
Open
rolandjitsu wants to merge 1 commit intomainfrom
Open
feat: use a custom error when items are not files#123rolandjitsu wants to merge 1 commit intomainfrom
rolandjitsu wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Hmm, interesting. Locally the tests are passing on node v20 😆 I'll have a look at it later this week, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Use a custom error for the
not a filecase so that users can inspect the item if they wish to.Does this PR introduce a breaking change?
Probably not.
Other information