Implement IEventLoopControl in RuntimeScheduler (#57403)#57403
Closed
lavenzg wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@lavenzg has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106744175. |
Summary: Pull Request resolved: react#57403 Make `RuntimeScheduler` implement `IEventLoopControl`. Wire `ReactInstance` to register that scheduler on Hermes runtimes that expose `ISetEventLoopControl`. Clear the pointer during teardown before `RuntimeScheduler` is destroyed. Regenerate React Native C++ API snapshots for the public header change. Only the modern scheduler have the actual implementation, it's no-op in the legacy scheduler. Changelog: [Internal] Reviewed By: javache Differential Revision: D106744175
lavenzg
force-pushed
the
export-D106744175
branch
from
40cdb16 to
88a5188
Compare
|
This pull request has been merged in f482ab6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Make
RuntimeSchedulerimplementIEventLoopControl.Wire
ReactInstanceto register that scheduler on Hermesruntimes that expose
ISetEventLoopControl.Clear the pointer during teardown before
RuntimeScheduleris destroyed.
Regenerate React Native C++ API snapshots for the public
header change.
Only the modern scheduler have the actual implementation, it's no-op
in the legacy scheduler.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D106744175