Add APIs to get classpaths and settings - #1212
Conversation
There was a problem hiding this comment.
determines whether the result should contain tests or not
There was a problem hiding this comment.
better show an example with multiple settings
Signed-off-by: Sheng Chen <sheche@microsoft.com>
Signed-off-by: Sheng Chen <sheche@microsoft.com>
| * but the classpaths might still be the same as before. | ||
| * 3. The Uri points to the project root path. | ||
| */ | ||
| readonly onDidClasspathUpdate: Event<Uri>; |
There was a problem hiding this comment.
In case of a multi-module project, changing a version in the parent pom only trigger an event with Uri of the root module, while all modules classpaths are affected. I don't think we can easily rebuild module hierarchy on our side, because of possible flat layout, so I wonder if you could fire multiple events (one per affected modules) in this case?
There was a problem hiding this comment.
I updated the code at the JDT.LS side: eclipse-jdtls/eclipse.jdt.ls#1312
Please try this bit: https://drive.google.com/open?id=1Mi320MyEtsgm1X-zhvylhmmcu5yQNPnF
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
@akaroml please give the latest CI build to your QA team as I can't generate an RC build as I'm on vacation |
|
@fbricon is this the latest ci build? https://download.jboss.org/jbosstools/jdt.ls/staging/?C=M;O=D |
|
Yes |
4 participants
This PR is to enable the SonarLint Java support in VS Code.
The context background can be found here: SonarSource/sonarlint-vscode#28
Related PR for JDT.LS: eclipse-jdtls/eclipse.jdt.ls#1312
Signed-off-by: Sheng Chen sheche@microsoft.com