frontend: move create AI Agent form to use Field component #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
this skill will be part of the UI registry in the future.
jvorcak
approved these changes
Dec 22, 2025
| placeholder="You are a helpful AI agent that..." | ||
| rows={8} | ||
| {...form.register('systemPrompt')} | ||
| aria-invalid={!!form.formState.errors.systemPrompt} |
Collaborator
There was a problem hiding this comment.
nit: should we add aria-describedby if we add aria-invalid if we can, since we're doing it properly now?
| value={field.value || []} | ||
| /> | ||
| ) : ( | ||
| <MCPEmpty> |
Collaborator
There was a problem hiding this comment.
Shall we add test-ids for these empty states for e2e?
| id="model" | ||
| placeholder="Enter model name (e.g., llama-3.1-70b)" | ||
| {...field} | ||
| aria-invalid={!!form.formState.errors[fieldNames.model]} |
Collaborator
There was a problem hiding this comment.
The same here, aria-describedby is doable I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form component migration to new Field pattern:
Added form-refactorer skill with migration docs & patterns
Total: 8 files changed, replaced FormField/FormItem/FormLabel/FormMessage with Field/FieldLabel/FieldDescription/FieldError across forms