Add reconcile deployment job and River observability middleware #8093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspersjo
force-pushed
the
reconcile-deployment
branch
2 times, most recently
from
81ad2d7 to
63a5352
Compare
kaspersjo
force-pushed
the
reconcile-deployment
branch
from
a532425 to
f4526b1
Compare
begelundmuller
requested changes
Nov 3, 2025
begelundmuller
requested changes
Nov 21, 2025
Comment on lines
+46
to
+71
| case database.DeploymentStatusRunning: | ||
| // Check current status to either start or update the deployment | ||
| if depl.Status == database.DeploymentStatusRunning { | ||
| // Update the deployment status to updating | ||
| depl, err = w.admin.DB.UpdateDeploymentStatus(ctx, depl.ID, database.DeploymentStatusUpdating, "Updating...") | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Update the deployment by updating its runtime instance and resources. | ||
| err := w.admin.UpdateDeploymentInner(ctx, depl) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } else { | ||
| // Update the deployment status to pending | ||
| depl, err = w.admin.DB.UpdateDeploymentStatus(ctx, depl.ID, database.DeploymentStatusPending, "Provisioning...") | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Initialize the deployment (by provisioning a runtime and creating an instance on it) | ||
| err := w.admin.StartDeploymentInner(ctx, depl) | ||
| if err != nil { | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
Does the DeploymentStatusError need special handling here? Or is it safe to call StartDeploymentInner for that?
Contributor
Author
There was a problem hiding this comment.
No special handling needed, it's safe since we go through the whole idempotent provisioning flow in StartDeploymentInner without assuming anything is already provisioned or otherwise healthy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a background reconcile job for deployments and removes all automatic project resets.
There's also a new River queue middleware added for better observability instrumentation of the background jobs.
Checklist: