Skip to content

[DOCS] AS requested, returning missing Keys #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 3 commits into from
Dec 10, 2025
Merged

[DOCS] AS requested, returning missing Keys #8286

begelundmuller merged 3 commits into from
Dec 10, 2025

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Nov 7, 2025

With the help of claude :)

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
begelundmuller
begelundmuller requested changes Dec 1, 2025
View reviewed changes
runtime/parser/schema/project.schema.yaml Outdated
Comment on lines 2024 to 2033
explore:
type: object
description: Defines an optional inline explore view for the metrics view. If not specified a default explore will be emitted unless `skip` is set to true.
properties:
skip:
type: boolean
description: If true, disables the explore view for this metrics view.
name:
type: string
description: Name of the explore view.
Copy link
Contributor

@begelundmuller begelundmuller Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing most of the old properties (like display_name, description, banner, theme, defaults, etc.)

See the old properties at the code highlighted in this comment: #7725 (comment)
Copy link
Contributor Author

@royendo royendo Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, was missing the whole section as shown in the comment.
@begelundmuller begelundmuller merged commit 974fba5 into main Dec 10, 2025
10 of 11 checks passed
@begelundmuller begelundmuller deleted the docs-schema-fix branch December 10, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@royendo @begelundmuller