Gracefully skip time dimensions referenced in defaults.dimensions
#8371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjain1
approved these changes
Nov 20, 2025
begelundmuller
deleted the
begelundmuller/fix-time-dimensions-exclude-explore
branch
begelundmuller
added a commit
that referenced
this pull request
Nov 20, 2025
…8371) * Gracefully skip time dimensions referenced in `defaults.dimensions` * Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a filter that skips time dimensions from the dimensions list in explore resources. This is a temporary workaround until the UI can handle multiple time dimensions. The PR is here: #8081
The PR did not account for explicitly referenced time dimensions under
defaults: dimensions:. This PR adds handling for that.Checklist: